search

pttlink / Asterisk

Version of asterisk used for PTTLink. And home of the original ASL code base repo.
Other
39 stars 34 forks source link

Changed morse code letter spacing #56

Closed JimZAH closed 4 years ago

JimZAH commented 4 years ago

Changed interlettertime from 4 -> 3. Sounds more natural.

KG7QIN commented 4 years ago

Thanks for the change.

It is missing DCO. Please fix.

DCO

You only have one commit incorrectly signed off! To fix, head to your local branch and run:

git commit --amend --signoff

Now your commits will have your sign off. Next run

git push --force-with-lease origin patch-1

Commit sha: 828417a, Author: JimZAH, Committer: GitHub; The sign-off is missing.
KG7QIN commented 4 years ago

Looking at this change, I'm wondering it this would be a good addition to the [globals] section of app_rpt, adding this in as one of the variables/settings available? You could then make this change both in the rpt.conf file as well as at run time via the CLI.

JimZAH commented 4 years ago

Thanks for the change.

It is missing DCO. Please fix.

DCO

You only have one commit incorrectly signed off! To fix, head to your local branch and run:

git commit --amend --signoff

Now your commits will have your sign off. Next run

git push --force-with-lease origin patch-1

Commit sha: 828417a, Author: JimZAH, Committer: GitHub; The sign-off is missing.

Sorry, will give that a go. I'm new to signing off commits!

JimZAH commented 4 years ago

Looking at this change, I'm wondering it this would be a good addition to the [globals] section of app_rpt, adding this in as one of the variables/settings available? You could then make this change both in the rpt.conf file as well as at run time via the CLI.

I agree, maybe a variable called farnsworth?

I'll adjust the give it a test at home and submit

JimZAH commented 4 years ago

Will close this request and re-open with farnsworth variable.