search

pttlink / Asterisk

Version of asterisk used for PTTLink. And home of the original ASL code base repo.
Other
39 stars 34 forks source link

Allow users to adjust morse code letter spacing #57

Closed JimZAH closed 4 years ago

JimZAH commented 4 years ago

Allows users to adjust morse code letter spacing.

Adding farnsworth = 3 under [morse] allows adjustment. Minimum is 3 which is also the default. 10 is maximum, when set to 10 the ID sounds similar to the Zetron 38A panels!

EG config: [morse] speed = 20 ; Approximate speed in WPM farnsworth = 3 ; Morse Letter Spacing frequency = 1750 ; Morse Telemetry Frequency amplitude = 4096 ; Morse Telemetry Amplitude idfrequency = 850 ; Morse ID Frequency
idamplitude = 3024 ; Morse ID Amplitude

KG7QIN commented 4 years ago

Ahhhh. All the white space.... removed.... ahhhh...... :)

coolacid commented 4 years ago

Thanks for the PR!

The team was doing a bunch of reviews tonight and we wanted to look at this PR. We're wondering if you could rebase the PR against lastest develop branch, and also not commit the white space changes.

Thanks, and looking forward to including!

JimZAH commented 4 years ago

On 2020-10-19 00:32, Stacy Olivas wrote:

@KG7QIN requested changes on this pull request.

Please resubmit without all the extraneous line edits involving whitespace removal.

Thank you.

-- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub [1], or unsubscribe [2].

Links:

[1] https://github.com/AllStarLink/Asterisk/pull/57#pullrequestreview-511278056 [2] https://github.com/notifications/unsubscribe-auth/ACOJ5BNS5LRIGF4U5AUDNDTSLN3KXANCNFSM4PQ5DBEQ

Thank you for taking a look at my PR. I will work to re-submit tonight (BST). -- Kind Regards James B Colderwood M0ZAH

JimZAH commented 4 years ago

Sorry for the delay, I will be submitting a new PR today.

JimZAH commented 4 years ago

opened a new pull request #66 Please forgive me, this is the first time I've really used git for collaboration