pttlink / Asterisk

Version of asterisk used for PTTLink. And home of the original ASL code base repo.
Other
39 stars 34 forks source link

Fixed IP status telemetry settings #68

Closed KG7QIN closed 3 years ago

KG7QIN commented 4 years ago

Signed-off-by: Stacy Olivas kg7qin@arrl.net

Fix for IP lookup status command issues created after PR that cached Public IP in sysinfo struct. Also adds local IP to sysinfo struct.

KG7QIN commented 4 years ago

The three status commands that "say" the Public and Local IP addresses were moved into sysinfo struct. This struct was created in a previous PR of which the goal was to eliminate a call to CURL to each call to "say" the public IP. Unfortunately, this created a few issues with the Public IP address being able to be announced status,20 and status,21 commands -- it would fail no matter what.

This also adds a routine to lookup the local IP address and save it in sysinfo. The routine will eventually be used in more than just a single place as it is now.

This also adds three additional items to be displayed at system status or when rpt globals show is issued: Public IP, Local interface and Local IP.

w0jrl commented 4 years ago

Are status,20 and status,21 both supposed to report the public IP address? I'm testing the fix now. "status,22" Reports the local IP address as long as "net_if = eth0".

KG7QIN commented 4 years ago

Are status,20 and status,21 both supposed to report the public IP address? I'm testing the fix now. "status,22" Reports the local IP address as long as "net_if = eth0".

The status codes 20-22 are something I added in when i started hacking on ASL 1.02.

20 and 21 both play the Public IP over the air on the radio, but one does not send the announcement over the link to other nodes.

And that is correct, 22 is for the local IP only. You need to ensure that you have the net_if = line in the [globals] section of rpt.conf set. It defaults to ens192 for the interface which will fail if yours is different.