search

ptvoinfo / zigbee-configurable-firmware

PTVO firmware for CC2530, CC2531, and CC2652 Zigbee chips
https://ptvo.info/zigbee-configurable-firmware-features/
MIT License
192 stars 22 forks source link

Tiny bug in generated custom ZHA device handler #258

Closed adamantivm closed 5 months ago

adamantivm commented 5 months ago

I noticed that the ZHA handlers saved with the configurator have some spaces after the manufacturer name, which causes ZHA to fail to load the device handler (quirk). Removing those extra spaces solves the problem as a workaround.

I'm using PTVO. Firmware Configuration 1.9.0.11 (Firmware: 2023-12-12). I've never changed the deafult manufacturer name, left it default, unchanged.

Here is an excerpt from such a generated quirk:

...

    signature = {
        MODELS_INFO: [("ptvo.info       ", PTVO_MODEL_ID)],
        ENDPOINTS: {
...

It's a minor annoyance, I thought I'd report it as it may be very easy to fix.

adamantivm commented 5 months ago

NOTE: If I change the default manufacturer name, the problem doesn't manifest itself, making this even less of an issue.

I would still suggest making it work well with the default value, as otherwise this adds another point of error for first time users (defaults don't work)

ptvoinfo commented 5 months ago

Could you please try the latest version of the configuration from the main web site? https://ptvo.info/download/ptvo-firmware-latest.zip?1

adamantivm commented 5 months ago

The updated worked @ptvoinfo. Quirks produced with the default manufacturer name using 1.9.0.14 ( 2023-12-12) don't include the extra spaces. Thanks for the quick update.