search

ptx2 / gymnasticon

Make obsolete and/or proprietary exercise bikes work with popular cycling training apps like Zwift, TrainerRoad, Rouvy and more.
https://ptx2.net/posts/unbricking-a-bike-with-a-raspberry-pi
MIT License
298 stars 39 forks source link

Code cleanup: Deprecate --flywheel-address in favor of --bike-address #70

Open chriselsen opened 3 years ago

chriselsen commented 3 years ago

Currently only the flywheel bike driver supports "locking" the bike to a certain Bluetooth MAC address via the --flywheel-address option. It would make sense to expand this capability to the other two Bluetooth enabled bike types (ic4, keiser) and as a result rename the option to --bike-address or --bike-mac-address.

There shouldn't be a need to do the same with --flywheel-name, as the LocalName for ic4 and keiser bikes is fixed. But with the flywheel bike, using the --flywheel-name option could be used to make gymnasticon work with a LifeFitness IC5.

goosebumps827 commented 2 years ago

Would you mind if i handled this for you guys?

nealjane commented 2 years ago

Hi Goosebumps - I think any help is much appreciated by us gymnastic users.