search

ptycho / ptypy

Ptypy - main repository
Other
37 stars 17 forks source link

ptypy > core > geometry > _keV2m #80

Closed cmkewish closed 7 years ago

cmkewish commented 7 years ago

Hi Bjoern,

I have a quick question: in PtyPy > core > geometry module, why is the hardcoded conversion of photon energy in keV to wavelength in meters:

_keV2m = 1.240597288e-09

instead of using the more common value:

hc = 1.23984193e-09 keV*m ?

bjoernenders commented 7 years ago

That is a good question. I don't recall how I came up with that number. It cold be historical reasons. 1.23984193e-09 is even on wikipedia. Are you used working with git on a locked master branch? If not, I suggest that you commit a fix to get used to it. If you are used to the procedure and think that is an unnecessary exercise, I can do a quick fix.

cmkewish commented 7 years ago

OK I will try to work out how to submit the changed file.

bjoernenders commented 7 years ago

Fix was accepted.