setBand() does not change BAND

[jun2sak]

Hello. I saw a problem that I cannot change the BAND parameter to cover all FM band range in my region. I guess setBand() does not properly set the internal parameter for BAND. I made the following modification, and it looks to work fine.

--- RDA5807.cpp.orig    2020-12-21 10:33:40.000000000 +0900
+++ RDA5807.cpp 2021-10-02 07:51:56.440127500 +0900
@@ -414,7 +414,7 @@
  */
 void RDA5807::setBand(uint8_t band)
 {
-    reg03->refined.BAND = band;
+    reg03->refined.BAND = this->currentFMBand = band;
     setRegister(REG03,reg03->raw);
 }

@@ -1027,4 +1027,4 @@
 {
     reg04->refined.RDS_FIFO_CLR = 1;
     setRegister(REG04, reg04->raw);

[pu2clr]

It makes sense. Thanks. I will check it out. Let me know your name to add you in the repository as a contributor.

Regards, Ricardo.

On Fri, Oct 1, 2021 at 8:39 PM jun2sak @.***> wrote:

Hello. I saw a problem that I cannot change the BAND parameter to cover all FM band range in my region. I guess setBand() does not properly set the internal parameter for BAND. I made the following modification, and it looks to work fine.

--- RDA5807.cpp.orig 2020-12-21 10:33:40.000000000 +0900 +++ RDA5807.cpp 2021-10-02 07:51:56.440127500 +0900 @@ -414,7 +414,7 @@ */ void RDA5807::setBand(uint8_t band) {

• reg03->refined.BAND = band;
• reg03->refined.BAND = this->currentFMBand = band; setRegister(REG03,reg03->raw); }

@@ -1027,4 +1027,4 @@ { reg04->refined.RDS_FIFO_CLR = 1; setRegister(REG04, reg04->raw);

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pu2clr/RDA5807/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVSJNFJIUPQHRC4V4PUGX3UEZBCDANCNFSM5FFV7RBQ .

--

QRZ: http://www.qrz.com/db/PU2CLR Skype: ricardo_caratti Mobile: +55 61 981442296

[pu2clr]

Thanks. I will commit your modification. Let me know your name to add you in the repository as a contributor.

[jun2sak]

Just using jun2sak is ok. Thank you.

[pu2clr]

Ok