pualixue / pe

0 stars 0 forks source link

Duplicate detection #8

Open pualixue opened 2 years ago

pualixue commented 2 years ago

Final and final are likely to be the same exam but it is not detected to be a duplicate.

image.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate exams can be added to a module

Steps to reproduce:

  1. Open the details view of any module.
  2. Add an exam to a module, e.g. add exam n/Final Exam d/31/12/2022 s/2100 e/2200 v/MPSH
  3. Add the same exam, but with a name in lower case, i.e. add exam n/final Exam d/31/12/2022 s/2100 e/2200 v/MPSH or with an extra space, i.e. add exam n/Final (extra space) Exam d/31/12/2022 s/2100 e/2200 v/MPSH

Expected: A user would expect 'Final Exam' to be the same exam as 'Final exam' or 'Final (extra space) Exam'. Repeating the command stated in step 2 above yields an error message warning about duplicate exams as well, so a user would expect to be warned about accidentally entering a duplicate exam.

Actual: The duplicate exam is added as per normal. (See Exams 5 & 6)

image.png


[original: nus-cs2103-AY2122S1/pe-interim#656] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This will appear only in very rare situations when the user forgets that he already added an exam and then attempt to create the exact same exam with an extra space or different casing. Even if this happens, this causes a minor inconvenience only since the user will just have to delete the duplicated exam.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: [replace this with your explanation]