search

puavo-org / externalportal

External sites portal widget for Nextcloud dashboard
GNU Affero General Public License v3.0
6 stars 2 forks source link

Add preview to Admin Settings page #2

Closed theCalcaholic closed 1 year ago

theCalcaholic commented 1 year ago

I like your app and recently had the issue, that it doesn't play very well with 1) theming and 2) light/dark mode, because the contrast between the icons and the widget isn't guaranteed to be good. So I decided to attempt implementing options for dynamic icon colors. This PR is a preparation for the second one which adds the actual feature :)

Adds a preview to the admin settings page

image

Mazhoon commented 1 year ago

Thank you, these look very nice! I'll test these out a bit later and see if there's anything to comment on. I'll probably start with this one as the changes seem so nice and compact, and continue with https://github.com/puavo-org/externalportal/pull/3 afterwards.

Mazhoon commented 1 year ago

Ok, everything looks nice and seems to work nicely. Spotted a small typo, but fixed it already in https://github.com/puavo-org/externalportal/commit/f8dd16746992715f85e0f34107f81f32916b32e5 . Thank you for this one, very nice! I'll continue with the next PR later.