Give more detailed error message in the "can't happen" branch of satisfier()

pubgrub-rs / pubgrub

PubGrub version solving algorithm implemented in Rust

https://pubgrub-rs.github.io/pubgrub/pubgrub/

Mozilla Public License 2.0

337 stars 30 forks source link

Give more detailed error message in the "can't happen" branch of satisfier() #103

Closed njsmith closed 2 years ago

njsmith commented 3 years ago

Example:

thread 'main' panicked at 'internal error: entered unreachable code: while processing package trio: accum_term = 0.19 isn't a subset of incompat_term = 0.19.0, which means the last assignment should have been a decision, but instead it was a derivation. This shouldn't be possible! (Maybe your Version ordering is broken?)', /home/njs/src/pubgrub/src/internal/partial_solution.rs:411:17 note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

Fixes: gh-102

Eh2406 commented 2 years ago

I am sorry, I wanted to make CI / Commit messages follow project guidelines happy and have this to count as merged. I seam not to have succeeded. and I force pushed to your njsmith:release. What a mess. Sorry.

Thank you for the contribution!

mpizenberg commented 2 years ago

I see @njsmith code in the dev branch so you merged it. But the website UI does not interpret it as such ... I think next time we have PRs with only the commit messages failing it's ok since we can simply change the commit message when doing the squash merge. No need to try make it pass within the PR.

Eh2406 commented 2 years ago

Right! I forget that I can reword it during the squash! That would have bean the correct solution.