search

pubgrub-rs / pubgrub

PubGrub version solving algorithm implemented in Rust
https://pubgrub-rs.github.io/pubgrub/pubgrub/
Mozilla Public License 2.0
337 stars 30 forks source link

More verbose debug assert #137

Closed konstin closed 8 months ago

konstin commented 8 months ago

Accidentally caused this error, added a better debug message

Eh2406 commented 8 months ago

Thank you! This looks good. When CI is green I will be happy to merge.

Can you elaborate on how you hit this error? I'm surprised a higher level / user facing check didn't catch the bug.

Eh2406 commented 8 months ago

(The commit message needs to follow "conventional commit" before I can merge.)

mpizenberg commented 8 months ago

(The commit message needs to follow "conventional commit" before I can merge.)

Nah, it's fine you rename the commit anyway when merging so you can conventionalize it @Eh2406

Eh2406 commented 8 months ago

@mpizenberg how can I check that the new message will make CI happy. I have messed up before and ended merging with a bad name and had red CI on dev, witch required doing a force push to fix, witch required turning off the branch protection. Witch is a mess I don't want to repeat.

mpizenberg commented 8 months ago

Ahah, ok makes sense ^^

konstin commented 8 months ago

commitlint passes locally, though i don't know if it matches the CI one.

Can you elaborate on how you hit this error? I'm surprised a higher level / user facing check didn't catch the bug.

iirc i was midway into refactoring that made more versions available (those with only a source distribution and lacking a wheel) in on place but not in another.