search

pubgrub-rs / pubgrub

PubGrub version solving algorithm implemented in Rust
https://pubgrub-rs.github.io/pubgrub/pubgrub/
Mozilla Public License 2.0
337 stars 29 forks source link

Add `Range::is_empty()` #189

Closed konstin closed 3 months ago

konstin commented 3 months ago

We use Range::is_empty() for special casing the empty version range in error messages. This mirrors std, which has is_empty methods on all of its collections: https://doc.rust-lang.org/nightly/std/?search=is_empty

Example usages:

https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L553

https://github.com/astral-sh/uv/blob/8d721830db8ad75b8b7ef38edc0e346696c52e3d/crates/uv-resolver/src/pubgrub/report.rs#L565

Eh2406 commented 3 months ago

For consistency with STD +1. The real question here is should RangeSet treat also have a is_empty or should it continue to use == VS::Empty()