search

pubgrub-rs / pubgrub

PubGrub version solving algorithm implemented in Rust
https://pubgrub-rs.github.io/pubgrub/pubgrub/
Mozilla Public License 2.0
337 stars 29 forks source link

CI is failing on dev. #218

Closed Eh2406 closed 1 month ago

Eh2406 commented 1 month ago

We have recently successfully merged PR's that failed "Commit messages follow project guidelines" CI.

  1. https://github.com/pubgrub-rs/pubgrub/actions/runs/8914690905/job/24482780384
  2. https://github.com/pubgrub-rs/pubgrub/actions/runs/8926571377/job/24517897487
  3. https://github.com/pubgrub-rs/pubgrub/actions/runs/8973450833/job/24643647093

We should either give up on this check. Or fix CI (do not let them merge) and reset the dev branch (do not have them in the history) and reemerged the PR's.

konstin commented 1 month ago

Personally, i don't think it adds value, but I'm not opposed to having it. We should change it though to run directly when you put the PR up instead of later as it used to.

Eh2406 commented 1 month ago

Personally, i don't think it adds value, but I'm not opposed to having it.

Same

We should change it though to run directly when you put the PR up instead of later as it used to.

I found that very annoying because CI would basically always be ❌, especially annoying when the commits it was mad about where going to get squashed away.

I am very troubled that CI let things merge after finding ❌. Why did that happen and what else got through?