search

pubgrub-rs / pubgrub

PubGrub version solving algorithm implemented in Rust
https://pubgrub-rs.github.io/pubgrub/pubgrub/
Mozilla Public License 2.0
337 stars 29 forks source link

ci: remove naming convention ci check #220

Closed konstin closed 1 month ago

konstin commented 1 month ago

This change switches pubgrub to commit messages without prefix.

Tagging everyone to sign off before merging.

Closes https://github.com/pubgrub-rs/pubgrub/issues/218

zanieb commented 1 month ago

How is the changelog going to work?

konstin commented 1 month ago

We can start using PR labels. Note that we're not really losing anything, the changelog structure is different than the commit labels

Eh2406 commented 1 month ago

The previous change logs were maintained manually. As no one volunteered to set up tooling that used the conventional commits. Considering approximately everything has changed since the last public release the next logs is going to be hand authored, even if we had tooling set up. So 🤷

zanieb commented 1 month ago

Ah if they're not being used for changelog generation than I'm pretty against conventional commit enforcement (but it's not really my project)

mpizenberg commented 1 month ago

Indeed, this was introduced by Alex, mainly for commit consistency. Considering the (deliberate) few number of releases, it made more sense to me to craft change logs and release notes manually.