search

pubgrub-rs / semver-pubgrub

Compatibility between VersionReq from semver and VersionSet from pubgrub
Mozilla Public License 2.0
5 stars 2 forks source link

Tests from semver #1

Closed Eh2406 closed 10 months ago

Eh2406 commented 10 months ago

Also bring in test from https://github.com/dtolnay/semver/blob/master/tests/test_version_req.rs

Eh2406 commented 10 months ago

Test are copied over https://github.com/pubgrub-rs/semver-pubgrub/commit/3b608efe739fbf8248872b3089c9ac92e1bc32b2 Still working on other forms of testing.

dtolnay commented 10 months ago

It would be good to indicate the license of the contents of tests/test_version_req.rs somewhere, because it is not MPL 2.0.

Eh2406 commented 10 months ago

Good call and sorry.

Eh2406 commented 10 months ago

I added clarification to the top of that file and the readme. Is that adequate/reasonable?

dtolnay commented 10 months ago

The original is licensed "MIT OR Apache-2.0" — this is not the relevant thing. The relevant thing is what is the license of that code in that file in your repo. People need to know what terms they need to comply with when redistributing the contents of semver-pubgrub repo, and separately, how they are required to license any contributions that they make to this repo, or "derivative works".

Separately, be aware that both the MIT license and Apache 2.0 license puts the onus on you to supply a copy of the license text. At least by my interpretation, this seems pretty unambiguous in both licenses. MIT: "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." Apache: "You must give any other recipients of the Work or Derivative Works a copy of this License"

I recommend reading through the entire license text to see if there is anything else you might have missed.

Eh2406 commented 10 months ago

Having taken the time to think about it, thank you for pointing out how this will confuse contributors. I think if I add the MIT and Apache-2.0 files, and an explanation to the relevant tests it will still be confusing to contributors. (Users are not affected. As semver is a dependency of this library. So users will need to obtain and abide by your licenses independently of what I do in my tests.) So I have removed the test file, not just from the working tree but from the history as well.