search

pubkey / rxdb

A fast, local first, reactive Database for JavaScript Applications https://rxdb.info/
https://rxdb.info/
Apache License 2.0
21k stars 1.02k forks source link

definition of CollectionCreator#methods #144

Closed rweng closed 7 years ago

rweng commented 7 years ago

In the current version, the CollectionCreator interface requires statics and methods to be an object with numbers as keys: https://github.com/pubkey/rxdb/blob/83bee8b693d385a80e56b7942f1d275be3f4466d/src/index.d.ts#L78

I guess that is a bug, because in the docs (and mongoose as far as I remember), this is the method name.

pubkey commented 7 years ago

Yes this is a bug. key: string is what we need. Also the function[] at the migration-strategies is wrong, there we need the number-keys.

pubkey commented 7 years ago

Fixed in #147