search

pubkey / rxdb

A fast, local first, reactive Database for JavaScript Applications https://rxdb.info/
https://rxdb.info/
Apache License 2.0
21k stars 1.02k forks source link

WebpackBin won't let us .then() after collection create / pouchSettings ignored? #204

Closed natew closed 7 years ago

natew commented 7 years ago

Case

Attempt to test pouchSettings skip_setup

Issue

Seems to not work on my local stack, can't test in webpackbin.

Info

https://www.webpackbin.com/bins/-KmnW5PpBMmOuw-xcjRo

I tried doing .then() in a few places but get a maximum call stack error in webpack bin.

natew commented 7 years ago

Looks like pouchSettings is a legit bug, from RxDatabase.js file, I see the settings look hardcoded.

pubkey commented 7 years ago

It looks like the webpack-bin in the issues_template is broken. WEbpackbin overwrote my template when I used it. :(

Here it does not has the call-stack-error.

I don't think the pouchSettings are hardcoded. Where have you found this?

natew commented 7 years ago

Just re-read and I see that was for internal collections, not RxCollection.create. Going to attempt bumping version and seeing if that fixes it.

natew commented 7 years ago

Could it be that you're passing these options as the third argument?

https://github.com/pubkey/rxdb/blob/eec3b033da47ad40bb0dccec3b74c77203a68fb4/src/RxDatabase.js#L401

In pouch docs it shows just two https://pouchdb.com/api.html#create_database

natew commented 7 years ago

Actually, had to reset my couchdb and for some reason that fixed it! Sigh...

pubkey commented 7 years ago

Is this solved?