search

pubkey / rxdb

A fast, local first, reactive Database for JavaScript Applications https://rxdb.info/
https://rxdb.info/
Apache License 2.0
21.57k stars 1.06k forks source link

Compatibility with Sylviejs #6522

Open joelbqz opened 3 days ago

joelbqz commented 3 days ago

I'm really happy working with RxDB on a personal project that will be open source, unfortunately I can't use premium plugins. I've forked the LokiJS storage adapter and replaced it with https://github.com/cfu288/SylvieJS which seems working well.

However I think @pubkey mentioned that there are some failing tests of RxDB for LokiJS, I'm wondering if you can provide me a little of guidance/more context in this regard so I can contribute in the SylvieJS and attempt to fix them.

Is here where I should be looking to? https://github.com/pubkey/rxdb/blob/master/test/unit/rx-storage-lokijs.test.ts

joelbqz commented 3 days ago

I just tried running:

test:node:lokijs and test:query-correctness-fuzzing:lokijs:node

both are passing ✅ 🤔

pubkey commented 1 day ago

If it works it works. I am not sure what exactly failed at the time I wrote that. I will not migrate the current loki storage to siliviejs. Instead it will be removed in the next major version because I do not want to maintain it anymore and RxDB has the memory-mapped storage which is technologically the better option. I think the best option would be if you have the silvie storage in your own repo/package and link to it from the RxDB docs here: https://rxdb.info/third-party-plugins.html