pubky / pkarr

Public Key Addressable Resource Records (sovereign TLDs)
https://app.pkarr.org
MIT License
153 stars 17 forks source link

Api inconsistency in resolve/relay_get #37

Closed dvc94ch closed 9 months ago

dvc94ch commented 9 months ago

Would be better if the relay_get returned a Result<Option<SignedPacket>>. An error should signal a networking error, no entry in the dht should return None.

It's also not clear why relay_put requires an owned packet. Since it gets serialized, a reference should be enough.

Nuhvi commented 9 months ago

@dvc94ch ICYMI #38