pubky / pubky-nexus

The Nexus between Pubky homeservers and Pubky-App social features.
MIT License
6 stars 1 forks source link

Fix/static-files-bugs #146

Closed amirRamirfatahi closed 4 weeks ago

amirRamirfatahi commented 1 month ago

Pre-submission Checklist

For tests to work you need a working neo4j and redis instance with the example dataset in docker/db-graph

SHAcollision commented 1 month ago

Hey @amirRamirfatahi PR looks good. I left 3 relevant comments that are non blocking.

Tests are failing

thread 'watcher::files::create::test_put_pubkyapp_file' panicked at tests/watcher/files/create.rs:53:41:
Created file was not found.

Overall I think this could be a bit simpler and even more functional if we just use a request body and POST requests. We are using this on the /stream/users/by-ids endpoint so it feels anyway ackward to both: use POST for this kind of request and use a GET stringified list for the same kind of request.