Closed amirRamirfatahi closed 4 weeks ago
Hey @amirRamirfatahi PR looks good. I left 3 relevant comments that are non blocking.
Tests are failing
thread 'watcher::files::create::test_put_pubkyapp_file' panicked at tests/watcher/files/create.rs:53:41:
Created file was not found.
Overall I think this could be a bit simpler and even more functional if we just use a request body and POST requests. We are using this on the /stream/users/by-ids
endpoint so it feels anyway ackward to both: use POST for this kind of request and use a GET stringified list for the same kind of request.
Pre-submission Checklist
cargo test
.cargo bench