Edits to transactions and donations disappear

public-accountability / littlesis-rails

LittleSis is a free database of who-knows-who at the heights of business and government

https://littlesis.org

GNU General Public License v3.0

100 stars 12 forks source link

Edits to transactions and donations disappear #1714

Open betsydupuis opened 2 months ago

betsydupuis commented 2 months ago

No error, the edits disappear sometimes. sometimes they stay

josephlacey commented 1 month ago

@betsydupuis Is this when a user is making an edit and the edit isn't saved? That seems concerning. Can you describe how to duplicate this even if its inconsistent?

betsydupuis commented 1 month ago

I think it has something to do with the input validation that parses the date format into iso or whatever the DB uses. The fail scenario with the monetary field is harder to replicate. This happens on donations and transactions.

Failed scenario:

Step 1

Step 2

Success scenario:

Step 1

Step 2

betsydupuis commented 1 month ago

Tried it using gibberish numbers for the date and I was able to replicate for the donation disappearing.

Step 1

Step 2