search

public-activity / public_activity

Easy activity tracking for models - similar to Github's Public Activity
MIT License
2.97k stars 336 forks source link

Cleanup unused Activity model generator #341

Closed ur5us closed 5 years ago

ur5us commented 5 years ago

FIXES #338

pokonski commented 5 years ago

Thanks, Juri!

ur5us commented 5 years ago

@pokonski This is going against https://github.com/chaps-io/public_activity/pull/154 long term (which I like a lot actually) but removes some confusion short term.

pokonski commented 5 years ago

Yep, good point. I'll see ask @jnraine if he is still interested in rebasing that PR on top of this change :)

ur5us commented 5 years ago

@pokonski Even if @jnraine is not interested, I am and could do that if you’re open to the proposed feature in general.

pokonski commented 5 years ago

Yep, definitely! That feature would be great to have :heart:

pokonski commented 5 years ago

Hmm, weird failure in CI, specs pass but rake task returns failure

pokonski commented 5 years ago

Ah I see, specs need adjustments, too:

File does not exist: generators/public_activity/activity/activity_generator

@ur5us can you also fix this?

ur5us commented 5 years ago

@pokonski Will do! I’m having trouble running the tests locally so had to push for CI.

pokonski commented 5 years ago

No worries, they do require a lot of setup and various DB servers running

pokonski commented 5 years ago

And merged, thanks a lot for this :grin:

davegson commented 5 years ago

this totally fell out of my radar, sorry @pokonski for not following up on my word. Even more then: thank you @ur5us!! 🎉

pokonski commented 5 years ago

@davegson if there's anyone with a broken radar, it's me :grin:

davegson commented 5 years ago

😅👍

ur5us commented 5 years ago

@pokonski Thank you.