public-assembly / curation-protocol

MIT License
29 stars 4 forks source link

Change name of Curator.sol to ERC721Curator.sol? #26

Open 0xTranqui opened 1 year ago

0xTranqui commented 1 year ago

This idea just came up while working on the readme. I think this could be really helpful for making the nft architecture of everything more obvious to devs specifically. One hold up is that it might inadvertently make ppl think u can only curate ERC721s. What say you @iainnash ??

iainnash commented 1 year ago

It's a little confusing imo because the curation contract can curate individual NFTs, 1155s, or even wallets. It itself being 721 compliant is a bonus perhaps not a core part of its functionality?

0xTranqui commented 1 year ago

good points -- I agree lets leave as is