environment variable stuff

public-assembly / flexible-docs

Flexible documentation.

https://docs.flexible.works/

MIT License

2 stars 0 forks source link

environment variable stuff #2

Closed 0xTranqui closed 1 year ago

0xTranqui commented 1 year ago

Two things:

highlighted text repeats "NEXT_DAO_ADDRESS" instead of "NEXT_ALCHEMY_KEY"

After recent convos with @salieflewis I believe we're gonna want to be able to throw a chainID in the environment variable flow to support testnet

salieflewis commented 1 year ago

This is what the env.example currently looks like sans the PA stuff.

NEXT_PUBLIC_SITE_TITLE='Public Assembly'
NEXT_PUBLIC_APP_ID='public-assembly'
NEXT_PUBLIC_SITE_DESCRIPTION="create what's missing"
NEXT_PUBLIC_TWITTER_HANDLE='pblcasmbly'
NEXT_PUBLIC_WEBSITE_URL='https://public---assembly.com'
NEXT_PUBLIC_CHAIN_ID=''
NEXT_PUBLIC_ALCHEMY_KEY=''
NEXT_PUBLIC_TOKEN_ADDRESS=''
NEXT_PUBLIC_PLATFORM_INDEX=''
NEXT_PUBLIC_WEB3STORAGE_TOKEN=''
NEXT_PUBLIC_REGISTRY_CONTRACT=''

One thing that might change is that the registry contract may be hardcoded in. Also, people can submit either Alchemy or Infura keys, not sure just yet how we'll best communicate that.

0xTranqui commented 1 year ago

I think registry contract can/should def be hardcoded in. semi related -- will ppl have the option to override the inputs into the theming variables? I imagine some ppl may want to just hardcode in theming variables and not deal with the whole IPFS thing

for the alchemy/infura bit, maybe just call it RPC Provider Key?

also cross posting this issue I added to dao-utils this morning, should prob add an (optional) zora api key slot, which will be necessary for ppl with platforms that get high levels of traction

Valcoholics commented 1 year ago

Waiting on a follow up on the final order of these, and I'm against calling it RPC.

salieflewis commented 1 year ago

Do you feel like there is a logical way to break them up? They can be in whatever order we choose. Here is my suggestion.

NEXT_PUBLIC_PLATFORM_INDEX=''"
NEXT_PUBLIC_TOKEN_ADDRESS=''"
NEXT_PUBLIC_ALCHEMY_KEY=''"
NEXT_PUBLIC_WEB3STORAGE_TOKEN=''"
NEXT_PUBLIC_CHAIN_ID=''"
NEXT_PUBLIC_SITE_TITLE=""
NEXT_PUBLIC_APP_ID="" (Probably going to get rid of this)
NEXT_PUBLIC_SITE_DESCRIPTION="" (May be getting rid of this)
NEXT_PUBLIC_TWITTER_HANDLE=""
NEXT_PUBLIC_WEBSITE_URL=""