search

public-awesome / cw-nfts

Examples and helpers to build NFT contracts on CosmWasm
Apache License 2.0
188 stars 180 forks source link

Use official cw2 #117

Closed llllllluc closed 10 months ago

llllllluc commented 1 year ago

As the comment suggested we should use 1.0.1 after https://github.com/CosmWasm/cw-plus/pull/858 is merged.

However there's still problem with this PR, if i try to build it i get

error[E0412]: cannot find type `VersionError` in crate `cw2`
  --> contracts/cw721-base/src/error.rs:14:26
   |
14 |     Version(#[from] cw2::VersionError),
   |                          ^^^^^^^^^^^^ not found in `cw2`

Looking at the cw2 contract here it does have the VersionError but it's added after 1.0.1, i think we need to republish cw-plus to fix this error.

larry0x commented 1 year ago

cw2 1.0.1 was released last year before VersionError was introduced. We need the Confio to make a new release of cw2 that includes it.

cc @webmaster128 @ueco-jb

chipshort commented 1 year ago

Sorry for the wait, I just released 1.1 with the changes

llllllluc commented 1 year ago

updated thanks everyone!

JakeHartnell commented 10 months ago

@llllllluc just needs a rebase! Will get some more reviewers on this.

llllllluc commented 10 months ago

actually i found cw2 is already bumped to 1.1.0 in this commit to main, closing this one. thanks everyone!