search

public-awesome / cw-nfts

Examples and helpers to build NFT contracts on CosmWasm
Apache License 2.0
186 stars 179 forks source link

move `mint()` and `update_ownership()` to `Cw721Execute` trait #136

Closed taitruong closed 3 weeks ago

taitruong commented 11 months ago

Saw this TODO:

https://github.com/CosmWasm/cw-nfts/blob/177a993dfb5a1a3164be1baf274f43b1ca53da53/contracts/cw721-base/src/execute.rs#L80

Since it Cw721Execute covers all execute msgs, imo above methods should also be part of this trait: https://github.com/CosmWasm/cw-nfts/blob/177a993dfb5a1a3164be1baf274f43b1ca53da53/packages/cw721/src/traits.rs#L18

@shanev, @larry0x, let me know whether u agree and I'll make a PR for this.

taitruong commented 3 weeks ago

Done in #161