public-awesome / cw-nfts

Examples and helpers to build NFT contracts on CosmWasm
Apache License 2.0
188 stars 180 forks source link

move cw721_base::msg::QueryMsg::Minter to cw721::msg::Cw721ExecuteMsgMinter? #138

Closed taitruong closed 1 month ago

taitruong commented 1 year ago

Afaik cw721 package is supposed to be used by consumer contracts - whilst cw721-base is for a custom cw721 contract. If consumer can query all kinds of data using package - except for minter, wherecw721_base is required. Shouldn't we move it there?

I remember goal of package having it close erc721 spec. But package also allows it querying for contract_info which doesn't exist in erc721.

If above msg should be moved, as a consequence cw-ownable should be part of package.

Also Extension is an optional part of ERC721. Maybe this should also be moved to package?

taitruong commented 1 month ago

fixed in v19