search

public-awesome / cw-nfts

Examples and helpers to build NFT contracts on CosmWasm
Apache License 2.0
186 stars 179 forks source link

Extension on mint message #143

Closed Morgandri1 closed 3 weeks ago

Morgandri1 commented 8 months ago

Why is Extension on MintMsg? Shouldnt the extensions be global throughout the contract?

If not, Extension should be Option<T> instead of T as this will make development easier.

taitruong commented 8 months ago

Imo similar to Response<T = Empty>. What we can do is defining ExecuteMsg<T=Empty, E=Empty>. Would simplify things.

Morgandri1 commented 8 months ago

Yeah, and I found that you can define extension as Option, but that’s more steps that are subjectively unnecessary, especially when trying to write clean and concise tests 

taitruong commented 3 weeks ago

Fixed in #161