search

public-awesome / cw-nfts

Examples and helpers to build NFT contracts on CosmWasm
Apache License 2.0
188 stars 180 forks source link

Move to cw721 package #161

Closed taitruong closed 3 months ago

taitruong commented 5 months ago

This PR only moves code from contracts to cw721 package - as a preparation for PR #156 (Major release v0.19: add CollectionInfo, RoyaltyInfo, updatable NFTs for creator, etc.).

@jhernandezb, @JakeHartnell, all checks passed - except lint checker fails with use of deprecated variant ...

I have marked deprecated usages with #[allow(deprecated)], but linter still complaints. Did the same in launchpad PR, but here it is all fine: https://github.com/public-awesome/launchpad/pull/668/

humanalgorithm commented 5 months ago

Can you better explain why we have this giant app centered around cw721 expiration? Shouldn't "expiration" kind of just be an option handed to a regular cw721 rather than a giant app?

taitruong commented 4 months ago

Can you better explain why we have this giant app centered around cw721 expiration? Shouldn't "expiration" kind of just be an option handed to a regular cw721 rather than a giant app?

cw721-expiration is specific - and should not be part for cw721-base. Besides contract is already part of previous version. This PR here just did some refactorings.