search

public-awesome / cw-nfts

Examples and helpers to build NFT contracts on CosmWasm
Apache License 2.0
189 stars 181 forks source link

cosmwasm v2 updates #172

Open mintthemoon opened 2 months ago

mintthemoon commented 2 months ago

I got this a bit farther than #160 (and redid a bit of PFC's work when I should have merged it in 🙈 but there's plenty new), still a few outstanding concerns so I'll keep this as a draft.

Outstanding issues:

  1. All migration and backwards compatibility tests have been removed, the upgrade to v2 introduces incompatibilities with the old contract versions and it isn't clear to me how to resolve this cleanly.
  2. Submessage/reply structure has changed in ways that aren't obvious how to handle, I made some attempt but some are still failing. This is only an issue for cw721-fixed-price.
  3. This is pointing at my fork of cw-plus-plus pending merge of larry0x/cw-plus-plus#25

Other than the ones mentioned, all tests (that I could find) are passing. I likely won't have bandwidth to look into any of these issues for at least the rest of this week so if anyone wants to take a stab at them feel free.

mintthemoon commented 2 months ago

Looking at those test runs, couple more updates I missed. Every single instance of Addr::unchecked and String::from or string literals as addresses in messages must be changed or we get those decode errors. Bit of a pain eh?

Buckram123 commented 4 weeks ago

Hey what is the progress on upgrade? We would like to use cw721 that supports cosmwasm v2!

Outstanding issues:

  1. Submessage/reply structure has changed in ways that aren't obvious how to handle, I made some attempt but some are still failing. This is only an issue for cw721-fixed-price.

Related to this issue https://github.com/CosmWasm/cosmwasm/issues/2253 and for testing: https://github.com/CosmWasm/cw-multi-test/issues/206

ash-burnt commented 2 weeks ago

We are also looking to use cw721 in a cosmwasm v2 environment. Is there anything we can do to help?

taitruong commented 2 weeks ago

I'll have a look at it, until then pls resolve conflicts and rebase main branch