Closed larry0x closed 1 year ago
- For dependency version numbers, only keep the first two digits (e.g.
v1.x.y
-->v1.x
). The 3rd digit marks non-breaking changes, so no need to hardcode it. Imo, better leaving it as a wildcard and let Rust compiler determine the most appropriate versions to use.
There can be good reason to do that. If you write "1.2.3" that means 1.2.0-1.2.2 are too low. Those versions might contain a bug you want to prevent in the codebase. Using 1.2 only includes those patch releases. Anyways, probably not important here.
- For dependency version numbers, only keep the first two digits (e.g.
v1.x.y
-->v1.x
). The 3rd digit marks non-breaking changes, so no need to hardcode it. Imo, better leaving it as a wildcard and let Rust compiler determine the most appropriate versions to use.There can be good reason to do that. If you write "1.2.3" that means 1.2.0-1.2.2 are too low. Those versions might contain a bug you want to prevent in the codebase. Using 1.2 only includes those patch releases. Anyways, probably not important here.
my understanding is that if i write 1.2, the compiler should automatically choose the latest, which is 1.2.3 in this example, unless there are conflicts making it unable to choose 1.2.3
my understanding is that if i write 1.2, the compiler should automatically choose the latest, which is 1.2.3 in this example, unless there are conflicts making it unable to choose 1.2.3
In the average case yes. But you still get lower version if:
my understanding is that if i write 1.2, the compiler should automatically choose the latest, which is 1.2.3 in this example, unless there are conflicts making it unable to choose 1.2.3
In the average case yes. But you still get lower version if:
- You have 1.2.2, 1.2.1, 1.2.0 in the lockfile already
- Some other crate pins version to e.g. "=1.2.2"
Good point, will change back
@webmaster128 I have downgraded the Rust version used in CI to 1.60.0 and use the full version numbers (1.x.y) for dependencies
Changes
Versioning
cosmwasm-std
to v1.1cw-plus
packages tov0.14
v0.14
to be consistent with cw-plusCI
Dependencies
Schema
cw_serde
decorator, and regenerate schema accordingly:cw721-base/src/helpers.rs
it imports the wrongPhantomData
:I assume this is because someone used editor auto-completion for imports...
Notes
QueryMsg::Extension
.query_msg.json
instead ofquery_msg_for__cw2891_query_msg.json
. The latter won't be picked up by the ts-codegen so is kinda useless.