public-convenience-ltd / toiletmap

API/UI server for the Great British Public Toilet Map
https://www.toiletmap.org.uk
MIT License
46 stars 11 forks source link

Add switch to design system #1599

Closed stphnnnn closed 11 months ago

stphnnnn commented 11 months ago

What does this change?

Resolves #1546

How was this tested?

Automated tests have not been changed as this should not change any behaviour, existing tests exist to ensure the text area inputs still work as intended.

The switch component has been manually tested in Storybook and in the application.

Accessibility

If applicable to your changes, have you:

Documentation

If applicable to your changes, have you:

github-actions[bot] commented 11 months ago

📦 Next.js Bundle Analysis for toiletmap

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 188.79 KB (🟡 +155 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (200 KB)
/ 12.16 KB 200.95 KB 100.48% (🟢 -0.06%)
/explorer/loos/[id] 16.49 KB 205.28 KB 102.64% (+/- <0.01%)
/login 1.51 KB 190.3 KB 95.15% (+/- <0.01%)
/loos/[id]/edit 44.74 KB 233.53 KB 116.77% (🟢 -0.06%)
/loos/add 44.23 KB 233.02 KB 116.51% (🟢 -0.06%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

cypress[bot] commented 11 months ago

Passing run #1094 ↗︎

0 63 0 0 Flakiness 0

Details:

Merge 6840c470215f4e6950335a59f2eec48304c0c6e3 into fe515ecc8d3f0d5815f0ce03cd38...
Project: GBPTM Commit: 145ad20ab8 ℹ️
Status: Passed Duration: 02:03 💡
Started: Nov 29, 2023 6:17 PM Ended: Nov 29, 2023 6:19 PM

Review all test suite changes for PR #1599 ↗︎

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
toiletmap ✅ Ready (Inspect) Visit Preview Nov 29, 2023 6:12pm
github-actions[bot] commented 11 months ago

📦 Next.js Bundle Analysis for toiletmap

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 188.79 KB (🟡 +155 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (200 KB)
/ 12.16 KB 200.95 KB 100.48% (🟢 -0.06%)
/explorer/loos/[id] 16.49 KB 205.28 KB 102.64% (+/- <0.01%)
/login 1.51 KB 190.3 KB 95.15% (+/- <0.01%)
/loos/[id]/edit 44.74 KB 233.53 KB 116.77% (🟢 -0.06%)
/loos/add 44.23 KB 233.02 KB 116.51% (🟢 -0.06%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

github-actions[bot] commented 11 months ago

📦 Next.js Bundle Analysis for toiletmap

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 188.79 KB (🟡 +156 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (200 KB)
/ 12.16 KB 200.96 KB 100.48% (🟢 -0.06%)
/loos/[id]/edit 44.74 KB 233.53 KB 116.77% (🟢 -0.06%)
/loos/add 44.23 KB 233.02 KB 116.51% (🟢 -0.06%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.