Use a custom cluster marker style

mxdvl commented 4 months ago

What does this change?

Before	After

How was this tested?

How have you tested your changes?

Locally with pnpm dev

Accessibility

If applicable to your changes, have you:

[ ] Tested with screen reader
[ ] Checked to see if navigable by keyboard
[X] Ensured that the colour contrast is passing

Documentation

If applicable to your changes, have you:

[ ] Added/edited the appropriate documentation
[ ] Added any component(s) to Storybook

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
toiletmap	✅ Ready (Inspect)	Visit Preview	May 17, 2024 3:11pm

github-actions[bot] commented 4 months ago

📦 Next.js Bundle Analysis for toiletmap

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`194.68 KB` (🟡 +74 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

cypress[bot] commented 4 months ago

Passing run #1181 ↗︎

0

63

0

Details:

Merge 04a5750d17968a97a721a7e3311b70aaea11b3db into bf1bff83010bbe2e6172c0a90a6e...
Project: GBPTM	Commit: `09a0aee7aa ℹ️`
Status: Passed	Duration: 01:58 💡
Started: May 17, 2024 3:14 PM	Ended: May 17, 2024 3:16 PM

Review all test suite changes for PR #1664 ↗︎

github-actions[bot] commented 4 months ago

📦 Next.js Bundle Analysis for toiletmap

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`194.68 KB` (🟡 +74 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

mxdvl commented 3 months ago

I’ve accepted the Chromatic diffs as they were only changes to the OSM map updates – but there isn’t a story capturing the marker styles. Should I create one?

ob6160 commented 3 months ago

I’ve accepted the Chromatic diffs as they were only changes to the OSM map updates – but there isn’t a story capturing the marker styles. Should I create one?

If it’s not too much extra effort to chuck in an extra map story with a marker cluster on it there’s no harm IMO.

I’m not massively bothered though as it should be quite obvious very quickly when testing if clusters look off if we capture it in Chromatic or not as it’s so core to the experience. Happy either way :)

mxdvl commented 3 months ago

If it’s not too much extra effort to chuck in an extra map story with a marker cluster on it there’s no harm IMO.

I’ve tried a few things, but I’m not understanding how to add marker groups to a story, so I’d prefer getting this in first and possibly improving this as a follow up.

github-actions[bot] commented 3 months ago

📦 Next.js Bundle Analysis for toiletmap

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`194.68 KB` (🟡 +74 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

ob6160 commented 3 months ago

If it’s not too much extra effort to chuck in an extra map story with a marker cluster on it there’s no harm IMO.

I’ve tried a few things, but I’m not understanding how to add marker groups to a story, so I’d prefer getting this in first and possibly improving this as a follow up.

sounds good - let's merge it!

👏 first loo map contribution 🚽

github-actions[bot] commented 3 months ago

📦 Next.js Bundle Analysis for toiletmap

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`194.68 KB` (🟡 +74 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

public-convenience-ltd / toiletmap