public-convenience-ltd / toiletmap

API/UI server for the Great British Public Toilet Map
https://www.toiletmap.org.uk
MIT License
42 stars 9 forks source link

New toilet location sometimes set incorrectly to the default #1669

Open ob6160 opened 4 months ago

ob6160 commented 4 months ago

Describe the problem

Sometimes, when toilets are being added, their location is set to the map default location instead of where the user presumably wanted them to be placed on the map.

Screenshot 2024-05-15 at 12 34 02

Some loos which have appeared here (all seem to be new):

Right now the solution is to try and have a best guess at the intended location or to delete the new contributions which isn't ideal.

To Reproduce

I haven't been able to reproduce this yet. It's possible that this is down to users forgetting to use the map placement interface and thus the location of the loo remaining at its default location (central london).

It's equally possible that there's a problem with updating the selected crosshair lat/lng when users are dragging to map to the intended location when adding a toilet, meaning that it isn't recorded properly.

Possible solution

If people are just forgetting / not setting the toilet location we could perhaps look into making dragging the map to set a location a requirement before they can add the loo?