The stopovers method supports the two options departuresAfter and arrivalBefore as discussed in #2 which is consistent with the options provided by journeys.
When querying for journeys, this is just fine, because most of (if not all) public transport APIs return journeys with an arrival before the given arrival time. But in the case of stopovers (so, departures and arrivals), the behavior tends to be different and to return public transport services arriving at the given stationafter the given time. (That's what the user would also expect, IMHO).
The option arrivalBefore seems misleading here. It would be good to be consistent with journeys options, but I think we should discuss the naming again (especially mentioning @derhuerst here as he had the idea in the issue mentioned above).
juliuste
commented
6 years ago
The
stopoversmethod supports the two optionsdeparturesAfterandarrivalBeforeas discussed in #2 which is consistent with the options provided byjourneys.When querying for journeys, this is just fine, because most of (if not all) public transport APIs return journeys with an arrival before the given arrival time. But in the case of
stopovers(so,departuresandarrivals), the behavior tends to be different and to return public transport services arriving at the givenstationafter the given time. (That's what the user would also expect, IMHO).The option
arrivalBeforeseems misleading here. It would be good to be consistent withjourneysoptions, but I think we should discuss the naming again (especially mentioning @derhuerst here as he had the idea in the issue mentioned above).