fptf 2.0.0 checklist - Githubissues

public-transport / friendly-public-transport-format

A format for APIs, libraries and datasets containing and working with public transport data.

Creative Commons Attribution Share Alike 4.0 International

125 stars 1 forks source link

fptf 2.0.0 checklist #37

Open juliuste opened 6 years ago

juliuste commented 6 years ago

Things we need to work on for fptf 2.0.0:

[x] add a code of conduct (?) #36
[x] decide on / implement stopover type #35
[ ] decide on major design changes proposed in #61
[ ] add the canceled attribute #27
[ ] decide on wether to "forbid" redundant origin/destination information in journeys #34
[ ] decide on proposed information up-to-dateness attribute #43
[ ] decide on modes / products #62

This issue's intention is not to rush publishing the next version, it should just provide a neat checklist for what we still have to work on.

derhuerst commented 6 years ago

[ ] make journey.price/leg.price an array of prices

juliuste commented 6 years ago

I like the idea of adding multiple prices to FPTF journeys, however I find it quite useful to have the current way of expressing sth. like this is the price you pay in the default class without any reductions and I feel like we should keep some form of expressing this. For example, one price in prices should have the attribute default: true, or something similar.

derhuerst commented 6 years ago

Not sure what the "default class" would be. Imagine a ferry with "car", "truck", "bicycle" and "without any" tickets; What would be the default?

Also there are more things than 1st/2nd/whatever class, e.g.

daily ticket vs single ride vs 10 rides
sparpreis vs regular price
tickets with better service

matkoniecz commented 6 years ago

daily ticket vs single ride vs 10 rides

In this case "single ride" is clearly a default value.

tickets with better service

Standard service would be a default price, "better service" sounds like "1st class"

Not sure what the "default class" would be. Imagine a ferry with "car", "truck", "bicycle" and "without any" tickets; What would be the default?

This is tricky, I imagine that it depends on situation, sometimes one case dominates (for car centric ferry where 99% people travel with car answer is obvious, for passenger oriented ferry with single place for occasional car answer is also obvious). But at least sometimes there is no obvious default - maybe allow "null" for such cases?

sparpreis vs regular price

sparpreis is not an English word, Google translate gives "saving award" what is not clear for me (though it seems obvious that default is "regular price")

matkoniecz commented 6 years ago

In general - in most situations there is a clear, standard price (without upgrades, special services, discounts etc) and it would be nice to have way to specify it.

derhuerst commented 6 years ago

tickets with better service

Standard service would be a default price, "better service" sounds like "1st class"

For a flight, would the default price include or exclude baggage?

But at least sometimes there is no obvious default - maybe allow "null" for such cases?

Agree! I'd definitely make the price.default/price.isDefault flag optional.

In general - in most situations there is a clear, standard price (without upgrades, special services, discounts etc) and it would be nice to have way to specify it.

I don't disagree! I'm only against having journey.price (which makes it awkward to expose multiple prices).

matkoniecz commented 6 years ago

For a flight, would the default price include or exclude baggage?

For me it would be the cheapest option (usually a small baggage is still allowed).

Though that is getting into subjective decisions.