public-transport / gtfs-rt-inspector

Web app to inspect & analyze any GTFS Realtime feed.
https://public-transport.github.io/gtfs-rt-inspector/
ISC License
33 stars 4 forks source link

refactoring and updates #7

Open ForsakenHarmony opened 3 years ago

ForsakenHarmony commented 3 years ago

Got a bit sidetracked, but this should fix #1 and #3

Closes #1 Closes #3

derhuerst commented 3 years ago

Hey, thanks for taking the time to fix #1 and #3!

Your PR introduces a lot of other changes though, and changes the whole repo structure; This makes it very hard to review it. Can you split it into several commits?

Also, some changes that I don't agree with:

ForsakenHarmony commented 3 years ago

hand-rolling query-string – I think it provides very nice defaults, is there a specific reason why you removed it?

to remove the dependency given it's only used in one place :upside_down_face:, I'll revert it when I get around to it

did you switch from underscores to camel casing because gtfs-realtime-bindings exposes the fields this way?

yes

some stylistic changes which make Git diffs noisier, e.g. export function

yes sorry, personal preferences (I consider default exports an anti-pattern), I'll remove them along with the revert above (again when and if I get around to it)