search

public-transport / hafas-client

JavaScript client for HAFAS public transport APIs.
ISC License
269 stars 54 forks source link

BVG BerlKönig has ended #272

Open olof-nord opened 1 year ago

olof-nord commented 1 year ago

The BVG BerlKönig offering ended on the 20th of July 2022.

Do we need to update the BVG profile, and/or adjust the BVG profile readme?

https://prod.berliner-zeitung.de/mensch-metropole/tschuess-berlkoenig-die-letzte-tour-durch-die-berliner-nacht-steht-bevor-li.248515

derhuerst commented 1 year ago

A PR that removes the BerlKönig-specific code would be great!

https://github.com/public-transport/hafas-client/blob/4189ce437bde4b33c0268baf4b94a0acf7b1d6a6/p/bvg/index.js#L111-L139

https://github.com/public-transport/hafas-client/blob/4189ce437bde4b33c0268baf4b94a0acf7b1d6a6/p/bvg/index.js#L160-L171

https://github.com/public-transport/hafas-client/blob/4189ce437bde4b33c0268baf4b94a0acf7b1d6a6/p/bvg/readme.md?plain=1#L24-L43

derhuerst commented 6 months ago

@olof-nord Do you want to submit a PR?

We could also look into if and how Muva is represented in their HAFAS endpoint. Let's do this in https://github.com/public-transport/hafas-client/issues/274.