search

public-transport / hafas-client

JavaScript client for HAFAS public transport APIs.
ISC License
269 stars 54 forks source link

dbProfile -> profile #278

Closed KristjanESPERANTO closed 1 year ago

KristjanESPERANTO commented 1 year ago

The examples in the docs don't work because profile is returned instead of dbProfile.

derhuerst commented 1 year ago

Thanks for pointing this out!

Can you adapt the imports to still keep the profile's name in the variable? I think it makes the code slightly more understandable. E.g. import {profile as dbProfile} from 'hafas-client/p/db/index.js'. 🙏

KristjanESPERANTO commented 1 year ago

Ok, I adjusted it like this :slightly_smiling_face:

KristjanESPERANTO commented 1 year ago

I just stumbled across a typo, sorry. But now I should be done.

derhuerst commented 1 year ago

Thank you! I have squashed and merged your commits in d8805d9.

KristjanESPERANTO commented 1 year ago

Nice. Should I do an extra PR for the typo? I obviously committed it too late.

derhuerst commented 1 year ago

I have cherry-picked the typo fix as fc1afe06.