search

public-transport / hafas-client

JavaScript client for HAFAS public transport APIs.
ISC License
277 stars 53 forks source link

apply leg-wide remarks if `opt.stopovers` is false #292

Closed traines-source closed 1 year ago

traines-source commented 1 year ago

I noticed that when stopovers=false, the remarks are missing entirely from journey legs.

Was there any reason to not just parse them? Maybe because it gets too bloated (loads of Komfort-Checkins, bicycle conveyance etc.)?

derhuerst commented 1 year ago

I noticed that when stopovers=false, the remarks are missing entirely from journey legs. Was there any reason to not just parse them? […]

I can't remember any reason. Thanks for this PR.

traines-source commented 1 year ago

Btw as far as I could tell the integration tests failed already before for some other reason, I didn't do anything about that

derhuerst commented 1 year ago

Do you want to be mentioned as a contributor? If you do, with which name and/or email?

traines-source commented 1 year ago

Thanks, but no need. And it's only one line :D