search

publicinteresttown / pit-jekyll

The publicinterest.town jekyll website
MIT License
3 stars 0 forks source link

GitHub Pages + GitHub Actions breaking config #4

Closed krusynth closed 1 year ago

krusynth commented 1 year ago

So I've manually created the GitHub Actions file that builds the main branch and pushes the results to the gh-pages branch, and that seems to be conflicting with the GitHub Pages configuration. On each push, it's deleting the custom domain. I suspect that that file needs to be deleted, and then the contents manually added through the GitHub interface. Seems like a bug in GitHub but in the meantime every deploy deletes the custom domain. Needs a fix ASAP.

BryceStevenWilley commented 1 year ago

I think this can be fixed by putting the CNAME file in main as well. Jekyll should just copy all of the files from the main branch when deploying, and I think it's getting removed because CNAME isn't in main.

krusynth commented 1 year ago

Hmm, the documentation says:

A CNAME file in your repository file does not automatically add or remove a custom domain. Instead, you must configure the custom domain through your repository settings or through the API. For more information, see "Managing a custom domain for your GitHub Pages site" and the Pages API reference documentation.

krusynth commented 1 year ago

Ok, I think that did the trick. But worth keeping an eye on!