search

publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
272 stars 285 forks source link

Transfer js code in index.html into separate .js file #1181

Closed segun-codes closed 2 years ago

segun-codes commented 2 years ago

index.html file currently contains Javascript code, this makes for a less readable and maintainable code especially as the codebase is set to become larger with more contributions from the community members. For this reason, it is important to transfer and maintain javascript code in a separate .js file different from the ./examples/index.html file as much as possible.

segun-codes commented 2 years ago

Hi @TildaDares @jywarren do you want to assign this issue? Not sure if it's qualifies as FTO or not.

If it does not qualifies as FTO, I'd like to claim this issue if okay by you.

jywarren commented 2 years ago

Hello, I wonder if maybe doing this for 1 file first would make a good example to follow, and then we could create FTOs for others based on that example? So perhaps if one of you would like to try the first one?

On Tue, Oct 18, 2022 at 12:18 PM Segun @.***> wrote:

Hi @TildaDares https://github.com/TildaDares @jywarren https://github.com/jywarren do you want to assign this issue? Not sure if it's qualifies as FTO or not.

If it does not qualifies as FTO, I'd like to claim this issue if okay by you.

— Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/issues/1181#issuecomment-1282655605, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J76PVLFGF5FRDHLDNTWD3EULANCNFSM6AAAAAARIHU37U . You are receiving this because you were mentioned.Message ID: @.***>

segun-codes commented 2 years ago

@jywarren, okay I'll try it. Thank you.

7malikk commented 2 years ago

@jywarren That sounds great @segun-codes We could leave it to @AndroGenius-codes as he just requested to work on the archive page You and i can work on converting the rest to FTOs, what do you say?

segun-codes commented 2 years ago

@jywarren That sounds great @segun-codes We could leave it to @AndroGenius-codes as he just requested to work on the archive page You and i can work on converting the rest to FTOs, what do you say?

@7malikk, okay... but not sure how we can achieve that. You can throw more light on this though. I thought @jywarren's idea is the way to go. One example, and then other first-timers can follow the example, something like that. The example from @AndroGenius-codes may just be all we need in the end.

7malikk commented 2 years ago

@segun-codes So what I'm trying to say is @AndroGenius-codes should make the correction (i.e moving the js to an external js file) Then you and I will create FTOs for the other issues. using @AndroGenius-codes implementation as an example.

Does this clarify things?

segun-codes commented 2 years ago

@segun-codes So what I'm trying to say is @AndroGenius-codes should make the correction (i.e moving the js to an external js file) Then you and I will create FTOs for the other issues. using @AndroGenius-codes implementation as an example.

Does this clarify things?

@7malikk, not to complicate things, let's just go by @jywarren's suggestion re-affirmed by @TildaDares. So I will simply fix this issue. The first-timers can re-apply from my input if @jywarren find it okay of course.

7malikk commented 2 years ago

@segun-codes So what I'm trying to say is @AndroGenius-codes should make the correction (i.e moving the js to an external js file) Then you and I will create FTOs for the other issues. using @AndroGenius-codes implementation as an example.

Does this clarify things?

@7malikk, not to complicate things, let's just go by @jywarren's suggestion re-affirmed by @TildaDares. So I will simply fix this issue. The first-timers can re-apply from my input if @jywarren find it okay of course.

@segun-codes check your dm for the meet link, I'll clarify what I'm saying there. It's in accordance with @jywarren's suggestion but with a better application.

Ibom99 commented 2 years ago

@jywarren can i try out https://github.com/publiclab/Leaflet.DistortableImage/issues/1184 as an example?

7malikk commented 2 years ago

@Ibom99 Hey there, @segun-codes already created a PR at #1186 regarding this. And is awaiting a review. What you should do is take a look at the above-mentioned PR and create an FTO from the changes made by @segun-codes.

It will provide issues for others to resolve. Just a thought, open to revision @jywarren @TildaDares @cesswairimu