publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
271 stars 284 forks source link

Display Bootstrap-like tooltips for menu items #1249

Open vanithaak opened 1 year ago

vanithaak commented 1 year ago

Fixes #104 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

gitpod-io[bot] commented 1 year ago

vanithaak commented 1 year ago

I have added the script and link tags in index.html , triggerred the tooltip in index.js , added attributes in EditAction.js, still I'm not able to see the tooltip when I hover. @jywarren What am I missing?

please review my pr. Thanks!

jywarren commented 1 year ago

I also want to suggest that we include some documentation. We shouldn't make Bootstrap a required dependency. I think this fails gracefully if it's not present, right? The only code that will fail is still in our examples/index.js file, not in the core library. But we can add a line to the README saying that to enable tooltip formatting, you can include a) Bootstrap 5 and b) the lines of code we're adding to index.js, to load these styles. How does that sound?

vanithaak commented 1 year ago

Sounds good! I'll start working on it