publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
273 stars 284 forks source link

Add polygon to searched country/state #1258

Open liryyy opened 2 years ago

liryyy commented 2 years ago

Fixes #1250 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

welcome[bot] commented 2 years ago

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌
Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

gitpod-io[bot] commented 2 years ago

liryyy commented 2 years ago

Hi @vanithaak , here is my changes for issue #1250. Could you please have a look at it? Thank you so much.

vanithaak commented 2 years ago

Hi @liryyy, good job! looks good to me. If you could add a GIF, it would be helpful for the mentors, to make a review. What do you think?

@jywarren, please review @liryyy's pr. Thanks!

jywarren commented 2 years ago

Wow, this looks really good! @vanithaak i was thinking, what if we made the polygon disappear after a few seconds? That way it doesn't interfere with your editing activities. Could we amend this with a setTimeout() and delete the polygon?

@liryyy great work here. You've done it just right, it seems. Can you upload a screencast video so we can confirm? Thanks!

vanithaak commented 2 years ago

Great idea! I'll see what we can do. Thanks Jeff

liryyy commented 2 years ago

@jywarren Thank you for your suggestion. Here is the video about the change that I made for this issue.

https://user-images.githubusercontent.com/11491275/201437805-1b89da29-1faf-454d-ab81-6df1a4e8c417.mp4

vanithaak commented 2 years ago

Hi @liryyy, thank you for the video. As Jeff mentioned, he would like us to add setTimeout(). I did try to add but I get an error in the geocode line inside the function. Would you please give a try ?

proy03 commented 1 year ago

@liryyy Hey, I am a enthusiastic newcomer and I would love to contribute. Could you please guide me through the same?