Closed segun-codes closed 1 year ago
Hi @jywarren, this PR is now ready for your kind review. Many thanks!
Note: This PR is based on your last suggestion to me on https://github.com/publiclab/Leaflet.DistortableImage/pull/1232 that I could provide functionality to replace http with https in user-supplied URLs on the welcomeModal.
Hi @jywarren @TildaDares, kindly review this PR. Many thanks!
Hi, this looks good. I still think inline comments would be helpful to show exactly which URL format is handled by each code block. But this is good enough to merge, thank you very much!
Maybe such comments could be added as an FTO!
Great work, thank you!!
Great work, thank you!!
Hi @jywarren, many thanks!
Maybe such comments could be added as an FTO!
Okay, nice idea.
Fixes #1262 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!