publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
271 stars 284 forks source link

Update archive.html to support url correction from http to https #1263

Closed segun-codes closed 1 year ago

segun-codes commented 1 year ago

Fixes #1262 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

http demo (1)

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

gitpod-io[bot] commented 1 year ago

segun-codes commented 1 year ago

Hi @jywarren, this PR is now ready for your kind review. Many thanks!

Note: This PR is based on your last suggestion to me on https://github.com/publiclab/Leaflet.DistortableImage/pull/1232 that I could provide functionality to replace http with https in user-supplied URLs on the welcomeModal.

segun-codes commented 1 year ago

Hi @jywarren @TildaDares, kindly review this PR. Many thanks!

jywarren commented 1 year ago

Hi, this looks good. I still think inline comments would be helpful to show exactly which URL format is handled by each code block. But this is good enough to merge, thank you very much!

jywarren commented 1 year ago

Maybe such comments could be added as an FTO!

jywarren commented 1 year ago

Great work, thank you!!

segun-codes commented 1 year ago

Great work, thank you!!

Hi @jywarren, many thanks!

segun-codes commented 1 year ago

Maybe such comments could be added as an FTO!

Okay, nice idea.