publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
271 stars 284 forks source link

Copy "location search" feature to archive.html #1272

Closed jywarren closed 1 year ago

jywarren commented 1 year ago

We have this great new feature for searching for locations:

https://publiclab.github.io/Leaflet.DistortableImage/examples/

image

However we want that same feature at the archive page:

https://publiclab.github.io/Leaflet.DistortableImage/examples/archive.html

It should be a pretty easy change! Here are the changes to index.html that made it possible: https://github.com/publiclab/Leaflet.DistortableImage/pull/1158/files

I'd love help with this! Maybe it could even be a first-timers-only issue?

jywarren commented 1 year ago

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!


rit-clone commented 1 year ago

Hi @jywarren I would love to work on this issue. Will you please assign it to me?

jywarren commented 1 year ago

Sure, please go ahead. No need to be assigned formally - thank you!

On Thu, Nov 24, 2022, 1:37 PM Ritika Dhamija @.***> wrote:

Hi @jywarren https://github.com/jywarren I would love to work on this issue. Will you please assign it to me?

— Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/issues/1272#issuecomment-1326764880, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J3H3XYBRPL2EK2SCP3WJ6YVXANCNFSM6AAAAAASCM5ELU . You are receiving this because you were mentioned.Message ID: @.***>

hs05june commented 1 year ago

https://github.com/publiclab/Leaflet.DistortableImage/pull/1286 Hey @jywarren . Once check my PR. I was struggling on a bug. I was unable to figure that out. Kindly suggest something.