Closed ayushkumarbhadani closed 1 year ago
Thanks for opening this pull request! Dangerbot
will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄
One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000
(for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌
Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅
@ayushkumarbhadani, I just realized the task of working on this PR was re-assigned to you. Since you have done the bulk of the work, to give this a final landing do you want to update the select.js as advised by @TildaDares?
This was resolved in https://github.com/publiclab/Leaflet.DistortableImage/pull/1291, thanks for attempting this @ayushkumarbhadani, closing this
fixes: #1185 created select.js and moved js from examples/select.html to examples/js/select.js