Closed segun-codes closed 1 year ago
Hi @jywarren, kindly review and consider for merging, many thanks!
This PR replaces PRs #1280 by @ayushkumarbhadani, #1274, #1278 & #1275 by @adityagoyal200, #1254 and #1255 by @Leeiaisabelle which were at various levels of completion and required further actions from affected contributors but the common denominator is that none was given final landing.
The task of closing out with this PR is as agreed with @7malikk.
Great work @segun-codes
Great work @segun-codes
Thanks!!!
And many thanks to @ayushkumarbhadani, @adityagoyal200, and @Leeiaisabelle for their work on these, which is being combined here! β€οΈ π
@jywarren, do you want to review and merge now so we call it day on this?
This PR replaces PRs #1280 by @ayushkumarbhadani, #1274 & #1278 by @adityagoyal200, #1254 and #1255 by @Leeiaisabelle & #1275 by @adityagoyal200.
Fixes #1185 and #1184
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!