publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
271 stars 284 forks source link

created function `renderImages` to handle image rendering #1292

Closed 7malikk closed 1 year ago

7malikk commented 1 year ago

Clean up archive.js - split image rendering functionality into a separate function

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

7malikk commented 1 year ago

@jywarren, here i created the renderImages function we spoke about here: https://github.com/publiclab/Leaflet.DistortableImage/pull/1290#discussion_r1045103863

jywarren commented 1 year ago

Great work!!! TY for the review @cesswairimu !!

7malikk commented 1 year ago

@cesswairimu Thanks a bunch, I will take your suggestions into consideration in other PRs.

Thank you @jywarren

segun-codes commented 1 year ago

Looks great 🎉 🎉

Side note: noticed commits from previous PRs are included, there is no harm with this but it looks cleaner and helps with squashing commits in merging- when to have only the new commits related to the new changes. Maybe you could consider this on future PRs?. A quick way to achieve this would be to create a new branch for each PR from the main branch or if you would like to continue working on the same branch, you could rebase your work branch with main before working on new changes here are some rebase steps]

Oh! @cesswairimu, many thanks. I will use this idea on subsequent contributions.