publiclab / Leaflet.DistortableImage

A Leaflet extension to distort or "rubber sheet" images
https://publiclab.github.io/Leaflet.DistortableImage/examples/
BSD 2-Clause "Simplified" License
271 stars 284 forks source link

drag n drop feature #1293

Closed 7malikk closed 1 year ago

7malikk commented 1 year ago

Fixes #998

Built on #1236 by @AndroGenius-codes

Made some improvements to the flow based on the discussions in #1236

local.html UI

localHtml

archive.html UI

localHtml-2

7malikk commented 1 year ago

Hello @jywarren, I finished this up, any pointers?

@cesswairimu Thanks for the pointer concerning numerous commits, it does look clean 😄

segun-codes commented 1 year ago

Hello @jywarren, I finished this up, any pointers?

@cesswairimu Thanks for the pointer concerning numerous commits, it does look clean 😄

@7malikk, great work!

7malikk commented 1 year ago

Thanks @segun-codes!!

jywarren commented 1 year ago

Hi, this looks really good! What do you think of possibly combining the "drag" message and the link to the archive.html message into a single box? And, should people be able to minimize that box? (these could also be done in a subsequent PR as well, if you'd like to merge this now, since functionally it looks great)

7malikk commented 1 year ago

Hi, this looks really good! What do you think of possibly combining the "drag" message and the link to the archive.html message into a single box? And, should people be able to minimize that box? (these could also be done in a subsequent PR as well, if you'd like to merge this now, since functionally it looks great)

I had the same thought, the "drag" text just floating there and the length of the box length was unsettling. I will address both in a subsequent PR, while this one is merged @jywarren Thank you!

jywarren commented 1 year ago

Sounds great, thanks!!